[PATCH] D132313: [Orc] Memory Mapper fixes

[Anubhab Ghosh via Phabricator via llvm-commits]

argentite updated this revision to Diff 454273.
argentite marked 4 inline comments as done.
argentite added a comment.

Addressed the above issues


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132313/new/

https://reviews.llvm.org/D132313

Files:
  llvm/lib/ExecutionEngine/Orc/MemoryMapper.cpp
  llvm/lib/ExecutionEngine/Orc/TargetProcess/ExecutorSharedMemoryMapperService.cpp


Index: llvm/lib/ExecutionEngine/Orc/TargetProcess/ExecutorSharedMemoryMapperService.cpp
===================================================================
--- llvm/lib/ExecutionEngine/Orc/TargetProcess/ExecutorSharedMemoryMapperService.cpp
+++ llvm/lib/ExecutionEngine/Orc/TargetProcess/ExecutorSharedMemoryMapperService.cpp
@@ -198,6 +198,17 @@
         AllErr = joinErrors(std::move(AllErr), std::move(Err));
       }
 
+      // Remove the allocation from the allocation list of its reservation
+      for (auto &Reservation : Reservations) {
+        auto AllocationIt =
+            std::find(Reservation.second.Allocations.begin(),
+                      Reservation.second.Allocations.end(), Base);
+        if (AllocationIt != Reservation.second.Allocations.end()) {
+          Reservation.second.Allocations.erase(AllocationIt);
+          break;
+        }
+      }
+
       Allocations.erase(Base);
     }
   }
@@ -264,22 +275,15 @@
 }
 
 Error ExecutorSharedMemoryMapperService::shutdown() {
-  std::vector<ExecutorAddr> ReservationAddrs;
-  {
-    std::lock_guard<std::mutex> Lock(Mutex);
+  if (Reservations.empty())
+    return Error::success();
 
-    if (Reservations.empty())
-      return Error::success();
-
-    ReservationAddrs.reserve(Reservations.size());
-    for (const auto &R : Reservations) {
-      ReservationAddrs.push_back(ExecutorAddr::fromPtr(R.getFirst()));
-    }
-
-    Reservations.clear();
-  }
+  std::vector<ExecutorAddr> ReservationAddrs;
+  ReservationAddrs.reserve(Reservations.size());
+  for (const auto &R : Reservations)
+    ReservationAddrs.push_back(ExecutorAddr::fromPtr(R.getFirst()));
 
-  return release(ReservationAddrs);
+  return release(std::move(ReservationAddrs));
 }
 
 void ExecutorSharedMemoryMapperService::addBootstrapSymbols(
Index: llvm/lib/ExecutionEngine/Orc/MemoryMapper.cpp
===================================================================
--- llvm/lib/ExecutionEngine/Orc/MemoryMapper.cpp
+++ llvm/lib/ExecutionEngine/Orc/MemoryMapper.cpp
@@ -305,7 +305,8 @@
   auto Reservation = std::lower_bound(
       Reservations.rbegin(), Reservations.rend(), AI.MappingBase,
       [](const auto &A, const auto &B) { return A.first > B; });
-  assert(Reservation != Reservations.rend() && "Attempt to initialize unreserved range");
+  assert(Reservation != Reservations.rend() &&
+         "Attempt to initialize unreserved range");
 
   tpctypes::SharedMemoryFinalizeRequest FR;
 
@@ -418,10 +419,9 @@
 
 #elif defined(_WIN32)
 
-  UnmapViewOfFile(R.second.LocalAddr);
+    UnmapViewOfFile(R.second.LocalAddr);
 
 #endif
-
   }
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132313.454273.patch
Type: text/x-patch
Size: 2602 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220821/0d2dd2b1/attachment.bin>