[PATCH] D132311: [llvm] Remove llvm::is_trivially_{copy/move}_constructible (NFC)

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 20 13:39:36 PDT 2022


kazu created this revision.
Herald added a project: All.
kazu requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This patch removes llvm::is_trivially_{copy/move}_constructible in
favor of std::is_trivially_{copy/move}_constructible.

The previous attempt to remove them in Dec 2020,
c8d406c93c5bb01599990201f78d8428dd29d289 <https://reviews.llvm.org/rGc8d406c93c5bb01599990201f78d8428dd29d289>, broke builds with "some
versions of GCC" according to
6cd9608fb37ca2418fb44b57ec955bb5efe10689 <https://reviews.llvm.org/rG6cd9608fb37ca2418fb44b57ec955bb5efe10689>.

It's been 20 months since then, and the minimum requirement for GCC
has been updated to 7.1 from 5.1.

FWIW, I was able to build llvm with gcc 8.4.0.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D132311

Files:
  llvm/include/llvm/ADT/FunctionExtras.h
  llvm/include/llvm/ADT/Optional.h
  llvm/include/llvm/ADT/SmallVector.h
  llvm/include/llvm/Support/type_traits.h
  llvm/unittests/Support/TypeTraitsTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132311.454248.patch
Type: text/x-patch
Size: 6168 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220820/d92c7707/attachment.bin>


More information about the llvm-commits mailing list