[PATCH] D110126: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on *BSD

Sat Aug 20 13:27:55 PDT 2022

MaskRay added a comment.

In D110126#3737497 <https://reviews.llvm.org/D110126#3737497>, @jrtc27 wrote:

> What is the arm vs armhf issue? FreeBSD uses arm-(unknown-)freebsd-gnueabi and -gnueabihf depending on the float ABI so the triples are different, if that's the question, though on RISC-V both riscv64 and riscv64sf exist but use the same triple

https://lab.llvm.org/buildbot/#/builders/178 (clang-armv8-lld-2stage, -mcpu=cortex-a57, `-DLLVM_ENABLE_PROJECTS=compiler-rt;llvm;clang-tools-extra;lld;clang`) used to fail with LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on.
It might be due to the subarch part "v8l". I don't know why it failed.

  -- LLVM host triple: armv8l-unknown-linux-gnueabihf
  -- LLVM default target triple: armv8l-unknown-linux-gnueabihf

`rg 'arm.*freebsd' clang/test` gives me `Frontend/gnu-mcount.c` (armv7-unknown-freebsd-gnueabihf). If a BSD doesn't use subarch for arm, I think it will likely work without any change. If a BSD uses arch for arm, there may be some risk. It'd be nice if someone can investigate the issue.

AIUI `-LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=off -DLLVM_ENABLE_PROJECTS=compiler-rt` uses the layout which is to be phased out (see https://discourse.llvm.org/t/rfc-time-to-drop-legacy-runtime-paths/64628).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110126/new/

https://reviews.llvm.org/D110126