[PATCH] D131376: [wasm-ld] Allow importing/exporting the output module's memory with arbitrary names

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 20 08:26:03 PDT 2022


sunfish added a comment.

In D131376#3737184 <https://reviews.llvm.org/D131376#3737184>, @sbc100 wrote:

> I think its probably simpler to only allow a single start `cabi_start` definition.. just like any other symbol.  It sounds like it should be a linker error to have more than one of them.

This sounds right to me. We already have the .init_array mechanism for registering constructors at link time, and it sounds like we can continue to use that with `cabi_start`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131376/new/

https://reviews.llvm.org/D131376



More information about the llvm-commits mailing list