[PATCH] D132216: [CostModel][X86] RFC - Support cost kind specific look up tables

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 20 01:22:19 PDT 2022


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:2727
     // slm pblendvb/blendvpd/blendvps throughput is 4
-    { ISD::SELECT,  MVT::v2f64,   4 }, // vblendvpd
-    { ISD::SELECT,  MVT::v4f32,   4 }, // vblendvps
-    { ISD::SELECT,  MVT::v2i64,   4 }, // pblendvb
-    { ISD::SELECT,  MVT::v8i32,   4 }, // pblendvb
-    { ISD::SELECT,  MVT::v8i16,   4 }, // pblendvb
-    { ISD::SELECT,  MVT::v16i8,   4 }, // pblendvb
+    { ISD::SELECT,  MVT::v2f64,   { 4, 4, 1, 3 } }, // vblendvpd
+    { ISD::SELECT,  MVT::v4f32,   { 4, 4, 1, 3 } }, // vblendvps
----------------
pengfei wrote:
> Do we have a place to introduce the meaning of each elements, where they are used and how to get the correct value?
> Besides, the previous comments are just for throughput? How can we explain the other values?
I'll tweak the description at the top of the file


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132216/new/

https://reviews.llvm.org/D132216



More information about the llvm-commits mailing list