[PATCH] D131925: Undef FS and CS macros for Android x86_64

Pirama Arumuga Nainar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 19 14:48:00 PDT 2022


pirama added a comment.

Adding the `#undef`s at the point of conflicting variable makes the fixes hard to read/maintain.  These macros are defined through the `#include <sys/ptrace.h>` in `lldb/source/Plugins/Process/Linux/Procfs.h`.  It may be cleaner to `#undef` these macros after the `#include` in `Procfs.h` with a comment.  We should also wrap the fix with a `#ifdef ANDROID`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131925/new/

https://reviews.llvm.org/D131925



More information about the llvm-commits mailing list