[PATCH] D117723: [NFCI] Move cost estimation from TargetLowering to TargetTransformInfo.
    Zheng Qian via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Aug 19 13:43:40 PDT 2022
    
    
  
qianzhen added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h:97
 
+  std::pair<InstructionCost, MVT> getTypeLegalizationCost(Type *Ty) const;
+
----------------
This function used to be a public member in TargetLowering (llvm/lib/Target/AMDGPU/SIISelLowering.h), is there a reason to declare it as a private member when it's moved in TTI? It makes this function inaccessible outside TTI.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117723/new/
https://reviews.llvm.org/D117723
    
    
More information about the llvm-commits
mailing list