[PATCH] D132181: [X86][AArch64][NFC] Simplify querying used argument registers

Bill Wendling via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 19 11:39:32 PDT 2022


This revision was automatically updated to reflect the committed changes.
Closed by commit rGac6a0cdc2e85: [X86][AArch64][NFC] Simplify querying used argument registers (authored by void).

Changed prior to commit:
  https://reviews.llvm.org/D132181?vs=453804&id=454071#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132181/new/

https://reviews.llvm.org/D132181

Files:
  llvm/lib/CodeGen/PrologEpilogInserter.cpp


Index: llvm/lib/CodeGen/PrologEpilogInserter.cpp
===================================================================
--- llvm/lib/CodeGen/PrologEpilogInserter.cpp
+++ llvm/lib/CodeGen/PrologEpilogInserter.cpp
@@ -1206,6 +1206,11 @@
             UsedRegs.set(Reg);
         }
 
+  // Get a list of registers that are used.
+  BitVector LiveIns(TRI.getNumRegs());
+  for (const MachineBasicBlock::RegisterMaskPair &LI : MF.front().liveins())
+    LiveIns.set(LI.PhysReg);
+
   BitVector RegsToZero(TRI.getNumRegs());
   for (MCRegister Reg : AllocatableSet.set_bits()) {
     // Skip over fixed registers.
@@ -1221,8 +1226,14 @@
       continue;
 
     // Want only registers used for arguments.
-    if (OnlyArg && !TRI.isArgumentRegister(MF, Reg))
-      continue;
+    if (OnlyArg) {
+      if (OnlyUsed) {
+        if (!LiveIns[Reg])
+          continue;
+      } else if (!TRI.isArgumentRegister(MF, Reg)) {
+        continue;
+      }
+    }
 
     RegsToZero.set(Reg);
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132181.454071.patch
Type: text/x-patch
Size: 979 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220819/f68def4a/attachment.bin>


More information about the llvm-commits mailing list