[PATCH] D131967: [RISCV] Correct costs for vector ceil/floor/trunc/round

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 19 11:32:44 PDT 2022


craig.topper added a comment.

In D131967#3735827 <https://reviews.llvm.org/D131967#3735827>, @reames wrote:

> In D131967#3735818 <https://reviews.llvm.org/D131967#3735818>, @craig.topper wrote:
>
>> Looking at my patch, I thought I increased the number of instructions for every version of ceil and floor, but the cost from your previous revision went from 16 to 15. Am I confused?
>
> As we discussed on that review, you're patch ended up removing 2 vsetvlis.  Since I was only discounting 1 of the original three, it's still a net savings of instructions.

I misread the description here and thought you discounted all vsetvlis, not just the first one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131967/new/

https://reviews.llvm.org/D131967



More information about the llvm-commits mailing list