[PATCH] D132181: [X86][AArch64][NFC] Simplify querying used argument registers
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 19 10:37:50 PDT 2022
nickdesaulniers accepted this revision.
nickdesaulniers added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1211
+ BitVector LiveIns(TRI.getNumRegs());
+ for (const auto &LI : MF.front().liveins())
+ LiveIns.set(LI.PhysReg);
----------------
RegisterMaskPair
================
Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1230-1234
+ if (OnlyUsed) {
+ if (!LiveIns[Reg])
+ continue;
+ } else if (!TRI.isArgumentRegister(MF, Reg)) {
+ continue;
----------------
This could probably be 2 statements rather than 5.
```
if ((OnlyUsed && !LiveIns[Reg]) || !TRI.isArgumentRegister(MF, Reg))
continue;
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132181/new/
https://reviews.llvm.org/D132181
More information about the llvm-commits
mailing list