[PATCH] D132194: Fix UB in DIExpression::appendOffset()

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/IR/DebugInfoMetadata.cpp:1388
     Ops.push_back(Offset);
-  } else if (Offset < 0) {
+  } if (Offset < 0) {
     Ops.push_back(dwarf::DW_OP_constu);
----------------
aprantl wrote:
> djtodoro wrote:
> > Orlando wrote:
> > > nit: the `else` appears to have gone missing
> > was `else` dropped intentionally? 
> whoops, thanks!
ooh, that might be worth implementing a warning for that at some point, like misleading indentation, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132194/new/

https://reviews.llvm.org/D132194