[PATCH] D131045: [NFC][AArch64] Precommit test to optimize instruction selection for aarch64_neon_pmull64 intrinsic.

[Mingming Liu via Phabricator via llvm-commits]

mingmingl updated this revision to Diff 454052.
mingmingl retitled this revision from "[NFC][AArch64] Precommit test for a tablegen pattern for aarch64_neon_pmull64" to "[NFC][AArch64] Precommit test to optimize instruction selection for aarch64_neon_pmull64 intrinsic.".
mingmingl edited the summary of this revision.
mingmingl added reviewers: efriedma, dmgreen.
mingmingl added a comment.

Update revision title and summary.  Use same comments for NFC and actual patch, so only assembly diff is shown in phabricator UI (not comment diff)

>From discussion with colleagues I should probably ask for review for both pre-commit tests and the actual change in the first place to ensure the quality of new test cases (e.g., not overly sensitive to changes that might make it brittle/likely to fail for unrelated reasons, not insufficiently minimized so that it's hard to maintain/read/possibly and more likely to fail for unrelated reasons, have good readability in terms of naming, etc)

So do it now and will remember to ask reviews for both in the future. Hope it's not too late!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131045/new/

https://reviews.llvm.org/D131045

Files:
  llvm/test/CodeGen/AArch64/aarch64-pmull2.ll
  llvm/test/CodeGen/AArch64/pmull-ldr-merge.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131045.454052.patch
Type: text/x-patch
Size: 6548 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220819/467b639c/attachment.bin>