[PATCH] D132194: Fix UB in DIExpression::appendOffset()
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 19 09:13:54 PDT 2022
aprantl added inline comments.
================
Comment at: llvm/lib/IR/DebugInfoMetadata.cpp:1388
Ops.push_back(Offset);
- } else if (Offset < 0) {
+ } if (Offset < 0) {
Ops.push_back(dwarf::DW_OP_constu);
----------------
djtodoro wrote:
> Orlando wrote:
> > nit: the `else` appears to have gone missing
> was `else` dropped intentionally?
whoops, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132194/new/
https://reviews.llvm.org/D132194
More information about the llvm-commits
mailing list