[PATCH] D132058: [RISCV] Add passthru operand to RISCVISD::SETCC_VL.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 19 08:47:15 PDT 2022


reames added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/fceil-sdnode.ll:20
 ; CHECK-NEXT:    flh ft0, %lo(.LCPI0_1)(a0)
-; CHECK-NEXT:    vsetvli zero, zero, e16, mf4, ta, ma
-; CHECK-NEXT:    vmflt.vv v0, v10, v8, v0.t
----------------
craig.topper wrote:
> reames wrote:
> > Purely as an aside, the fact we had two redundant vsetvlis and managed to get rid of them after this change is interesting.
> The mask policies were different. We do a bad job of using mask agnostic today.
You're right.  I swear I checked the policy bits before commenting, but apparently my brain swapped "mu" and "ma" at least once.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132058/new/

https://reviews.llvm.org/D132058



More information about the llvm-commits mailing list