[PATCH] D132233: [CGP][ARM] Dont align memcpy args when optimization for size

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 19 08:21:36 PDT 2022


SjoerdMeijer added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/memcpy-no-inline.ll:31
 }
 
+define void @bar2() #0 {
----------------
I understand the logic of this patch, but I am struggling with the tests.
In this new test below, it's unclear to me why we shouldn't be generating the libcall. 

To make the differences clear I am wondering if these tests should test more or if they should be `llc .. | llvm-objdump -d ..` tests so that we can actually see codesize?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132233/new/

https://reviews.llvm.org/D132233



More information about the llvm-commits mailing list