[PATCH] D132218: [debuginfo][CorrelatedValuePropagation] Missing debug location after replacement in processSRem function

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer accepted this revision.
StephenTozer added a comment.
This revision is now accepted and ready to land.

Change LGTM, one minor nitpick with the test. Also as a general rule, as per [[ https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface | the LLVM Phabricator review guide  ]]you should produce the diff with full context (i.e. add `-U999999` to the git command).



================
Comment at: llvm/test/Transforms/CorrelatedValuePropagation/srem_missing_debugloc.ll:2
+; RUN: opt -passes=correlated-propagation -S < %s | FileCheck %s
+; COM: Check whether the debug location is preserved.
+; CHECK: %{{[a-zA-Z0-9_]*}} = urem i8 %x.nonneg, %y.nonneg, !dbg ![[DBGLOC:[0-9]+]]
----------------
There's nothing incorrect with the COM directive here, but it's generally only needed if the commented line actually contains a directive.


================
Comment at: llvm/test/Transforms/CorrelatedValuePropagation/srem_missing_debugloc.ll:29-30
+
+attributes #0 = { inaccessiblememonly nocallback nofree nosync nounwind willreturn }
+attributes #1 = { nocallback nofree nosync nounwind readnone speculatable willreturn }
+
----------------
Unless these attributes are necessary for the test, they can be deleted from here and the functions that use them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132218/new/

https://reviews.llvm.org/D132218