[PATCH] D125953: [DebugInfo][InstrRef] Handle joins PHI+Def values in LiveDebugValues

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando accepted this revision.
Orlando added a comment.

The new test LGTM (& Jeremy has reviewed the rest)



================
Comment at: llvm/test/DebugInfo/MIR/X86/instr-ref-join-def-vphi.mir:229
+    CALL64pcrel32 @"?bar@@YAHXZ", csr_win64, implicit $rsp, implicit $ssp, implicit-def $rsp, implicit-def $ssp, implicit-def $eax, debug-location !31
+    DBG_INSTR_REF 5, 0, !14, !DIExpression(), debug-location !16
+
----------------
StephenTozer wrote:
> Orlando wrote:
> > I'm confused; there isn't a `debug-instr-number 5` and there are no `debugValueSubstitutions` - what am I missing here?
> bb.3, `DBG_PHI $esi, 5`
Ah right, gottcha.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125953/new/

https://reviews.llvm.org/D125953