[PATCH] D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly.

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 19 02:35:19 PDT 2022


simon_tatham updated this revision to Diff 453935.
simon_tatham marked 2 inline comments as done.
simon_tatham edited the summary of this revision.
simon_tatham added a comment.
Herald added a subscriber: kristof.beyls.

Moved the check for data symbols to before we choose symbols to display, so that the same check can control which symbol is printed //and// how the data after it is disassembled.

Added a test for the changed behaviour of `--disassemble-all`, and tweaked comments and layout in existing tests for review comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131589/new/

https://reviews.llvm.org/D131589

Files:
  llvm/test/tools/llvm-objdump/ELF/ARM/disassemble-all.s
  llvm/test/tools/llvm-objdump/ELF/data-vs-code-priority.test
  llvm/test/tools/llvm-objdump/multiple-symbols.test
  llvm/tools/llvm-objdump/ObjdumpOpts.td
  llvm/tools/llvm-objdump/llvm-objdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131589.453935.patch
Type: text/x-patch
Size: 25560 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220819/f53a8237/attachment.bin>


More information about the llvm-commits mailing list