[PATCH] D125953: [DebugInfo][InstrRef] Handle joins PHI+Def values in LiveDebugValues

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

The new test looks good but I have one question (inline).



================
Comment at: llvm/test/DebugInfo/MIR/X86/instr-ref-join-def-vphi.mir:71-73
+  attributes #0 = { mustprogress uwtable "frame-pointer"="none" "min-legal-vector-width"="0" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "tune-cpu"="generic" }
+  attributes #1 = { "frame-pointer"="none" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "tune-cpu"="generic" }
+  attributes #2 = { nocallback nofree nosync nounwind readnone speculatable willreturn }
----------------
I think you could delete all these attributes


================
Comment at: llvm/test/DebugInfo/MIR/X86/instr-ref-join-def-vphi.mir:229
+    CALL64pcrel32 @"?bar@@YAHXZ", csr_win64, implicit $rsp, implicit $ssp, implicit-def $rsp, implicit-def $ssp, implicit-def $eax, debug-location !31
+    DBG_INSTR_REF 5, 0, !14, !DIExpression(), debug-location !16
+
----------------
I'm confused; there isn't a `debug-instr-number 5` and there are no `debugValueSubstitutions` - what am I missing here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125953/new/

https://reviews.llvm.org/D125953