[PATCH] D131954: [LoongArch] Support Load and Store with 14-bit signed immediate operands

[Gong LingQin via Phabricator via llvm-commits]

gonglingqin added inline comments.


================
Comment at: llvm/test/CodeGen/LoongArch/ldptr.ll:5
+
+define signext i32 @ld_w(ptr %p) nounwind {
+; LA32-LABEL: ld_w:
----------------
SixWeining wrote:
> How about rename to `ldptr_w_too_small_offset` and write some comments for this test:
> ```
> ;; Check that ldptr_w is not emitted for samll offsets.
> ```
Thanks, I will change it.


================
Comment at: llvm/test/CodeGen/LoongArch/ldptr.ll:21
+
+define signext i32 @ldptr_w(ptr %p) nounwind {
+; LA32-LABEL: ldptr_w:
----------------
SixWeining wrote:
> Write some comments before this test:
> ```
> ;; Check that ldptr_w is emitted for applicable offsets.
> ```
Thanks, I will change it.


================
Comment at: llvm/test/CodeGen/LoongArch/ldptr.ll:39
+
+define signext i32 @ldx_w(ptr %p) nounwind {
+; LA32-LABEL: ldx_w:
----------------
SixWeining wrote:
> How about rename to `ldptr_w_too_big_offset` and write some comments for this test:
> ```
> ;; Check that ldptr_w is not emitted for out-of-range offsets.
> ```
Thanks, I will change it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131954/new/

https://reviews.llvm.org/D131954