[PATCH] D132195: [BOLT] Add data to code relocations postprocessing

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 18 23:41:41 PDT 2022


Amir added inline comments.


================
Comment at: bolt/lib/Core/BinaryContext.cpp:998
+
+  std::unordered_set<BinaryFunction *> Functions;
+  std::unordered_set<const MCSymbol *> EntryPoints;
----------------
tschuett wrote:
> Are you tied to `unordered_set` ?  There are more memory-efficient data structures:
> https://llvm.org/docs/ProgrammersManual.html#set-like-containers-std-set-smallset-setvector-etc
Thanks for a tip! No, a SmallPtrSet is probably a better data structure here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132195/new/

https://reviews.llvm.org/D132195



More information about the llvm-commits mailing list