[PATCH] D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata

[Matthew Voss via Phabricator via llvm-commits]

ormris added inline comments.


================
Comment at: llvm/tools/llvm-reduce/DeltaManager.cpp:70
     DELTA_PASS("metadata", reduceMetadataDeltaPass)                            \
+    DELTA_PASS("dimetadata", reduceDIMetadataDeltaPass)                        \
     DELTA_PASS("arguments", reduceArgumentsDeltaPass)                          \
----------------
aeubanks wrote:
> I wonder if we should move the metadata passes later where we should already have removed as many potential metadata havers, e.g. after `instructions` or `ir-passes`
Good point. I've run some tests locally and it seems like moving it after the instructions pass saves a few seconds. I'll change the patch.

| Position | Time (s) |
| Current | 85.3 |
| Last | 81.8 |
| After instructions | 80.96 |


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132077/new/

https://reviews.llvm.org/D132077