[PATCH] D113107: Support of expression granularity for _Float16.

Thu Aug 18 17:56:26 PDT 2022

pengfei added inline comments.

================
Comment at: clang/test/Sema/Float16.c:13
-
-#ifdef HAVE
 _Complex _Float16 a;
----------------
rjmccall wrote:
> I don't know why these test changes are in this patch.  My understanding is that we already committed a patch to enable `_Float16`, and this patch is just implementing the specialized emitter to avoid intermediate rounding when AVX512FP16 isn't available.
> 
> In the review of that other patch, I argued why this is the wrong change for this test.
Good catch! I guess the initial patch changed in the right way and directly rebased on D128571.

I think we can reset the change in this and the following file. We don't need to check for `avx512fp16` since it always implies `SSE2` but check for single `i686-linux-pc` is needed because it doesn't imply `SSE2`.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113107/new/

https://reviews.llvm.org/D113107