[PATCH] D131309: [ELF] Add ability to get a symbol by name from the hash table section

Joseph Huber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 18 15:04:56 PDT 2022


jhuber6 added a comment.

In D131309#3733520 <https://reviews.llvm.org/D131309#3733520>, @MaskRay wrote:

> OK. I don't understand OpenMP and GPU enough to comment on that patch.
> The DT_HASH support will have some utilitization if mips is to be supported. How good is LLVM's support for OpenMP/GPU on mips?

I think `libomp` should work, but not for GPU offloading with `libomptarget` as none of the offloading plugins target MIPS. I guess my understanding is that the compiler will typically emit both `HASH` and `GNU_HASH` sections and we previously used the old `DT_HASH` because it was simpler. We could probably switch over to using the GNU version and it would still work. I still feel like if this works already we may as well support this function for both `DT_HASH` and `DT_GNU_HASH`, but you're obviously more qualified to make that judgement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131309/new/

https://reviews.llvm.org/D131309



More information about the llvm-commits mailing list