[PATCH] D132102: [DirectX] Fix crash on ShuffleVectorInst in DXILBitcodeWriter

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: llvm/test/tools/dxil-dis/shuffle.ll:6
+; Make sure shufflevector works for DXIL bitcode writer.
+; CHECK:shufflevector
+
----------------
The change impacts both the encoding of `alloca` and `shufflevector` instructions.

Your test should verify that those instructions are correctly encoded and decoded, not just that a given instruction name shows up in the output.


================
Comment at: llvm/test/tools/dxil-dis/shuffle.ll:26
+!3 = !{i32 7, !"frame-pointer", i32 2}
\ No newline at end of file

----------------
Please add newline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132102/new/

https://reviews.llvm.org/D132102