[PATCH] D132018: [docs] Add LICENSE.txt to the root of the mono-repo

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 18 06:38:27 PDT 2022


kristof.beyls added a comment.

In D132018#3731050 <https://reviews.llvm.org/D132018#3731050>, @thieta wrote:

> How about a list of subdirectories with different licenses in the end of the top level LICENSE file? Then there is no need to keep the text in sync but only add / remove to the list in the end of the file when we add or remove a third-party dependency, which should be pretty infrequent.

Before we installed the new license, that is the scheme that we had, see e.g. https://github.com/llvm/llvm-project/blob/eb60fbfdb43cb8583eda1e338b3489ddef332f10/llvm/LICENSE.TXT for what the license file looked like for the llvm sub-directory. You can see that at the end of the license file there is a list of directories that contains differently licensed code.

When we still had that scheme in the LICENSE files, when people asked me what licenses were in an LLVM binary, I pointed to the combined list of directories in those LICENSE files. But also stated that there was no absolute guarantee that they were perfectly kept up to date. Based on that experience, I'd say that just mentioning that there are directories or files with a different license + how you can find them would be good enough, rather than trying to keep the list of directories up to date.
I'm also not opposed to explicitly listing the directories/files in the LICENSE file, i.e. doing what we did before by listing the directories with different licenses - assuming we also somehow state that the list is kept up-to-date based on "best efforts", rather than guaranteed to always be fully correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132018/new/

https://reviews.llvm.org/D132018



More information about the llvm-commits mailing list