[PATCH] D127964: [DCE] Eliminate no-op atan and atan2 calls

Thu Aug 18 03:41:28 PDT 2022

ro added a comment.

The `llvm/test/Transforms/EarlyCSE/atan.ll` test `FAIL`s on Solaris (both sparcv9 and amd64):

  /vol/llvm/src/llvm-project/local/llvm/test/Transforms/EarlyCSE/atan.ll:55:15: error: CHECK-NEXT: expected string not found in input
  ; CHECK-NEXT: ret float -0.000000e+00
                ^

Comparing to the Linux/x86_64 version of the output, the only difference is

  --- /homes/ro/atan.ll.x86_64	2022-08-18 12:38:48.313115000 +0200
  +++ /homes/ro/atan.ll.sparcv9	2022-08-18 11:50:22.976866000 +0200
  @@ -25,7 +25,8 @@
   }

   define float @callatan2_00() {
  -  ret float -0.000000e+00
  +  %call = call float @atan2f(float -0.000000e+00, float 0.000000e+00)
  +  ret float %call
   }

   define float @callatan2_x0() {

Any suggestion on how to handle this?  Just `XFAIL` the test on Solaris?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127964/new/

https://reviews.llvm.org/D127964