[PATCH] D79483: [CostModel] Replace getUserCost with getInstructionCost.

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 18 02:46:29 PDT 2022


samparker added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:304
 
-  /// This is a helper function which calls the two-argument getUserCost
+  /// This is a helper function which calls the two-argument getInstructionCost
   /// with \p Operands which are the current operands U has.
----------------
nit: three-argument


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfoImpl.h:505
+    // Assume a 3cy latency for fp arithmetic ops.
+    if (CostKind == TTI::TCK_Latency) {
+      if (Ty->getScalarType()->isFloatingPointTy())
----------------
Would it be better, for now, to keep this in the X86 backend, if you need it there?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79483/new/

https://reviews.llvm.org/D79483



More information about the llvm-commits mailing list