[PATCH] D132108: [LoongArch] Add some fixups and relocations

[WÁNG Xuěruì via Phabricator via llvm-commits]

xen0n added a comment.

This is something we all have been longing for. I'm still studying the other targets for the current coding practices in this area but at least the test case changes seem very sane. Many thanks.

Can't wait to run some native tests with this applied ;-)



================
Comment at: llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchMCExpr.h:27
+    // TODO: Add more target kinds.
+    VK_LARCH_None,
+    VK_LARCH_CALL,
----------------
>From a quick grep, the middle part should be spelled the same as the target name, i.e. the names should look like `VK_LoongArch_XXX` instead. Don't use the binutils convention ("LARCH") as the "larch" abbreviation is in fact not seen anywhere outside binutils.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132108/new/

https://reviews.llvm.org/D132108