[PATCH] D113291: [AggressiveInstCombine] Lower Table Based CTTZ

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

In D113291#3728796 <https://reviews.llvm.org/D113291#3728796>, @spatel wrote:

> Why are some test files still specifying a triple in the RUN line?

Leftovers. Thanks.

> It would be good to consolidate tests into less files if possible with better names/comments to explain exactly what differences are being tested in the sequence of tests. There should also be negative tests (wrong table constants, wrong magic multiplier, wrong shift amount, etc), so we know that the transform is not firing on mismatches.

I will remove one redundant test. There are C producers as well as some top-level comments that explain what it should test (if the comment is needed). Furthermore, thanks for the suggestion for adding some negative tests - will add it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113291/new/

https://reviews.llvm.org/D113291