[PATCH] D130520: [BOLT] Make exception handling fragment aware

Rafael Auler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 17:11:10 PDT 2022


rafauler accepted this revision.
rafauler added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: bolt/lib/Core/BinaryFunction.cpp:1579-1580
       BC.UndefinedSymbols.insert(LI.second);
-    if (FunctionEndLabel)
-      BC.UndefinedSymbols.insert(FunctionEndLabel);
+    if (!FunctionEndLabels.empty() && FunctionEndLabels.front())
+      BC.UndefinedSymbols.insert(FunctionEndLabels.front());
   }
----------------
Why are we not putting all end labels here?


================
Comment at: bolt/lib/Core/BinaryFunction.cpp:2850-2851
       BC.UndefinedSymbols.insert(LI.second);
-    if (FunctionEndLabel)
-      BC.UndefinedSymbols.insert(FunctionEndLabel);
+    if (!FunctionEndLabels.empty() && FunctionEndLabels.front())
+      BC.UndefinedSymbols.insert(FunctionEndLabels.front());
   }
----------------
Why are we not putting all end labels here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130520/new/

https://reviews.llvm.org/D130520



More information about the llvm-commits mailing list