[PATCH] D127779: [LTO][ELF] Add --lto-exit-on option

[Jin Xin Ng via Phabricator via llvm-commits]

Northbadge abandoned this revision.
Northbadge added a comment.

It's been //a bit// more than 2 weeks, but the idea I had didn't exactly pan out.

For future reference, in case someone revisits this: The idea was to concatenate the postimport .bc file with its associated thinlto index file (which is also bitcode). The naive way of doing this was to use llvm-dis on both the bitcode files, append the thinlto.ll lines to the postimport.ll lines and use llvm-as to go back to bitcode. This worked on small toy examples, but crashed on larger, real, files (Something about the asm/bitcode reader/writer, iirc, didn't have time to look into it further). The motivation for doing this was so that we can run lld with a single "hermetic" module which included the necessary index entries to prevent the deletion of locally-dead(not used within own module but used in other modules) functions. This would've allowed MLGO to use lld to perfectly replicate the ThinLTO environment when it is used in a non-distributed manner, and would've necessitated this patch to prevent the linker from crashing due to missing symbols.

Abandoning the patch as I won't be working on this in the near future. Thanks for all the feedback and guidance!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127779/new/

https://reviews.llvm.org/D127779