[PATCH] D132018: [docs] Add LICENSE.txt to the root of the mono-repo

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 12:28:45 PDT 2022


kristof.beyls added a comment.

In D132018#3729830 <https://reviews.llvm.org/D132018#3729830>, @tonic wrote:

> In D132018#3729809 <https://reviews.llvm.org/D132018#3729809>, @lattner wrote:
>
>> This is a great idea, thank you for doing this.  I think we should also point out the sublicenses that are not llvm licensed, e.g. we have a copy of PCRE, googletest etc, and should notify people about these things.
>
> Agreed. We need to make sure that all licenses (ie MIT License as well)  are accounted for here otherwise it makes things confusing if someone assumes everything is under only this license.
>
> Otherwise I like this idea. I'm slightly concerned about it getting out of date if we add any other code with some new license.

I think the current license text already calls this out with this paragraph:

>
>
>
> Software from third parties included in the LLVM Project:
> =========================================================
>
> The LLVM Project contains third party software which is under different license
> terms. All such code will be identified clearly using at least one of two
> mechanisms:
>
> 1. It will be in a separate directory tree with its own `LICENSE.txt` or `LICENSE` file at the top containing the specific license and restrictions which apply to that software, or
> 2. It will contain specific license and restriction terms at the top of every file.

Maybe that could be improved by trying to point to all such different license terms in the tree - but as already mentioned, that has the downside of easily getting out-of-date.

However, maybe this whole point is an orthogonal discussion?
It seems to me that the github interface will just add a hyperlink to the license file, without trying to guess what the license is?

Maybe the only thing to be verified before landing this change is that every sub-directory has an identical LICENSE.TXT file to the one in the LLVM sub-directory? So that the one LICENSE.TXT in the root directory is identical to all LICENSE.TXT files in sub-directories. If so, maybe there would also be no use anymore for the LICENSE.TXT files in the first-level sub-directories?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132018/new/

https://reviews.llvm.org/D132018



More information about the llvm-commits mailing list