[PATCH] D130391: revert "[CodeGen] Require a name for a block addr target"

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers marked an inline comment as done.
nickdesaulniers added a comment.

Bumping for review



================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:232
   Entry.Fn = BB->getParent();
-  MCSymbol *Sym = BB->hasAddressTaken() ? Context.createNamedTempSymbol()
-                                        : Context.createTempSymbol();
-  Entry.Symbols.push_back(Sym);
+  Entry.Symbols.push_back(Context.createTempSymbol());
   return Entry.Symbols;
----------------
barannikov88 wrote:
> The old behavior is to call `createNamedTempSymbol`
> I can't judge if the new behavior is wrong or not, just noticed that it has changed.
Correct; I'm intentionally reverting that behavior.

The regression in llvm/test/CodeGen/RISCV/inline-asm-S-constraint.ll was due to a different patch in the series, https://reviews.llvm.org/D130323, which I've removed from the dependency chain for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130391/new/

https://reviews.llvm.org/D130391