[PATCH] D130647: [BOLT] Add randomN split strategy
Fabian Parzefall via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 17 11:50:36 PDT 2022
FPar added a comment.
In D130647#3727346 <https://reviews.llvm.org/D130647#3727346>, @ayermolo wrote:
> In D130647#3727323 <https://reviews.llvm.org/D130647#3727323>, @FPar wrote:
>
>> In D130647#3727316 <https://reviews.llvm.org/D130647#3727316>, @ayermolo wrote:
>>
>>> Now that we have multiple of these Spilt* structs, does it make sense to have a base abstract class that enforces interface?
>>
>> Yes. I do have that in a local commit already. Do you think I should insert that in front of D129827 <https://reviews.llvm.org/D129827>?
>
> I don't have a strong opinion one way or the other.
See D132054 <https://reviews.llvm.org/D132054>.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130647/new/
https://reviews.llvm.org/D130647
More information about the llvm-commits
mailing list