[PATCH] D131454: [AArch64][GlobalISel] Fallback to generic lowering of G_CTPOP

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 10:52:34 PDT 2022


paquette added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:1232
+      MI.getMF()->getFunction().hasFnAttribute(Attribute::NoImplicitFloat)) {
+    if (Ty.isScalar() && (Size == 32 || Size == 64)) {
+      return Helper.lowerBitCount(MI) ==
----------------
I think this can be simplified into a one-liner?

```
  return Ty.isScalar() && (Size == 32 || Size == 64) &&
         Helper.lowerBitCount(MI) == LegalizerHelper::LegalizeResult::Legalized;
```

Also can you add a comment explaining why you want this behaviour?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131454/new/

https://reviews.llvm.org/D131454



More information about the llvm-commits mailing list