[PATCH] D131749: [MCDwarf] Respect -fdebug-prefix-map= for generated assembly debug info (DWARF v5)

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 10:43:23 PDT 2022


MaskRay added a comment.

In D131749#3729268 <https://reviews.llvm.org/D131749#3729268>, @srj wrote:

> This change has injected a build breakage for MSVC builds:
>
> `MCContext.cpp(859): error C2429: language feature 'structured bindings' requires compiler flag '/std:c++17'`

This turns out to be a backport issue. `release/15.x` (https://github.com/llvm/llvm-project/tree/release/15.x) uses C++14 and structured bindings trigger warnings in GCC/Clang and errors in MSVC.
My bad that I did not think of the difference when crafting the patch.
Pushed a trivial commit to release/15.x to avoid structured bindings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131749/new/

https://reviews.llvm.org/D131749



More information about the llvm-commits mailing list