[PATCH] D131220: [NFC][MLGO] ML Regalloc Priority Advisor

[Eric Wang via Phabricator via llvm-commits]

Flpha0830 marked 3 inline comments as done.
Flpha0830 added inline comments.


================
Comment at: llvm/lib/CodeGen/RegAllocGreedy.cpp:363
+
+  return static_cast<float>(Prio);
 }
----------------
MatzeB wrote:
> Did you consider the precision loss that can happen when casting a 32bit unsigned number to 32bit float?
Thanks for pointing this out. Because ML prefers small, bounded float values, we probably need float values. We can address this subsequently. 


================
Comment at: llvm/lib/CodeGen/RegAllocPriorityAdvisor.h:1
+//===- RegAllocPriorityAdvisor.h - Interference resolution ------*- C++ -*-===//
+//
----------------
MatzeB wrote:
> MatzeB wrote:
> > This comment seems off/wrong.
> You marked this comment as "done", but this still reads "interference resolution" which I am pretty sure makes no sense.
Thanks for the catch. This time it's fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131220/new/

https://reviews.llvm.org/D131220