[PATCH] D131356: [InstCombine] reassociate bitwise logic chains based on uses

Wed Aug 17 04:36:10 PDT 2022

spatel added a comment.

In D131356#3727970 <https://reviews.llvm.org/D131356#3727970>, @bcl5980 wrote:

> Sorry for the confused comments. This patch is OK for me. It helps on the cases with non-bool types that ipsccp can't tough. Put them to reassociate pass could avoid the potential dead loop in instcombine, but for now reassociate pass still have the history code don't work for i1 types.
> And I'm also trying to fix on ipsccp to eliminate all similar issues with i1 types.

Improving ipsccp seems good independently. I also looked at trying to solve the i1 pattern as a special-case using isImpliedCondition() from ValueTracking, but then I tried this instcombine idea, and it worked on the motivating cases plus others.

If there are no objections, would someone approve the patch formally?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131356/new/

https://reviews.llvm.org/D131356