[llvm] 594c5b1 - [SLP] Update TODO comment about shuffle mask decoding

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 03:49:03 PDT 2022


Author: Simon Pilgrim
Date: 2022-08-17T11:41:46+01:00
New Revision: 594c5b1a42cfc1b83a23d096e16586ccc8503532

URL: https://github.com/llvm/llvm-project/commit/594c5b1a42cfc1b83a23d096e16586ccc8503532
DIFF: https://github.com/llvm/llvm-project/commit/594c5b1a42cfc1b83a23d096e16586ccc8503532.diff

LOG: [SLP] Update TODO comment about shuffle mask decoding

This is handled in ShuffleVectorInst/getShuffleCost - getInstructionThroughput is (slowly) being removed.

Added: 
    

Modified: 
    llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
index f5dc66c282d41..926c30bf8b212 100644
--- a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -345,7 +345,7 @@ static bool isUndefVector(const Value *V) {
 /// InstCombiner transforms this into a shuffle and vector mul
 /// Mask will return the Shuffle Mask equivalent to the extracted elements.
 /// TODO: Can we split off and reuse the shuffle mask detection from
-/// TargetTransformInfo::getInstructionThroughput?
+/// ShuffleVectorInst/getShuffleCost?
 static Optional<TargetTransformInfo::ShuffleKind>
 isFixedVectorShuffle(ArrayRef<Value *> VL, SmallVectorImpl<int> &Mask) {
   const auto *It =


        


More information about the llvm-commits mailing list