[PATCH] D85415: [Sparc] Don't use SunStyleELFSectionSwitchSyntax

Rainer Orth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 03:46:17 PDT 2022


ro added a comment.

In D85415#3707384 <https://reviews.llvm.org/D85415#3707384>, @MaskRay wrote:

> For Linux, this makes sense. sparc64-linux-gnu-gcc uses the GNU style section directive. If Solaris may prefer SunStyleELFSectionSwitchSyntax, you can add a condition.

I don't think I'll bother: `/bin/as` cannot even assemble a trivial `test.s` emitted without this patch (use of `.p2align`, `@function` instead of `#function`).  I won't even think about what happens for real-world code.  If anything, I'll sometime finish my patch to make sure `/usr/gnu/bin/as` is used on Solaris with `-fno-integrated-as`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85415/new/

https://reviews.llvm.org/D85415



More information about the llvm-commits mailing list