[llvm] 49223e0 - [TypePromotion] Don't promote PHI + ZExt if wider than RegisterBitWidth
Andre Vieira via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 17 01:55:35 PDT 2022
Author: Andre Vieira
Date: 2022-08-17T09:54:15+01:00
New Revision: 49223e0a2df3d52d61dc982167bcbb3cfbbc3da2
URL: https://github.com/llvm/llvm-project/commit/49223e0a2df3d52d61dc982167bcbb3cfbbc3da2
DIFF: https://github.com/llvm/llvm-project/commit/49223e0a2df3d52d61dc982167bcbb3cfbbc3da2.diff
LOG: [TypePromotion] Don't promote PHI + ZExt if wider than RegisterBitWidth
Differential Revision: https://reviews.llvm.org/D131966
Added:
llvm/test/Transforms/TypePromotion/ARM/phi-zext-gep.ll
llvm/test/Transforms/TypePromotion/ARM/phi-zext-gep2.ll
Modified:
llvm/lib/CodeGen/TypePromotion.cpp
Removed:
################################################################################
diff --git a/llvm/lib/CodeGen/TypePromotion.cpp b/llvm/lib/CodeGen/TypePromotion.cpp
index 1ffa52b2f0b40..5ed2674fe6533 100644
--- a/llvm/lib/CodeGen/TypePromotion.cpp
+++ b/llvm/lib/CodeGen/TypePromotion.cpp
@@ -952,7 +952,13 @@ bool TypePromotion::runOnFunction(Function &F) {
<< "\n");
EVT ZExtVT = TLI->getValueType(DL, I.getType());
Instruction *Phi = static_cast<Instruction *>(I.getOperand(0));
- MadeChange |= TryToPromote(Phi, ZExtVT.getFixedSizeInBits());
+ auto PromoteWidth = ZExtVT.getFixedSizeInBits();
+ if (RegisterBitWidth < PromoteWidth) {
+ LLVM_DEBUG(dbgs() << "IR Promotion: Couldn't find target "
+ << "register for ZExt type\n");
+ continue;
+ }
+ MadeChange |= TryToPromote(Phi, PromoteWidth);
} else if (auto *ICmp = dyn_cast<ICmpInst>(&I)) {
// Search up from icmps to try to promote their operands.
// Skip signed or pointer compares
diff --git a/llvm/test/Transforms/TypePromotion/ARM/phi-zext-gep.ll b/llvm/test/Transforms/TypePromotion/ARM/phi-zext-gep.ll
new file mode 100644
index 0000000000000..8b6b3094202de
--- /dev/null
+++ b/llvm/test/Transforms/TypePromotion/ARM/phi-zext-gep.ll
@@ -0,0 +1,43 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -mtriple=arm -type-promotion -verify -S %s -o - | FileCheck %s
+
+; Function Attrs: mustprogress nofree nosync nounwind uwtable
+define dso_local void @foo(ptr noundef %ptr0, ptr nocapture noundef readonly %ptr1, ptr nocapture noundef %dest) local_unnamed_addr {
+; CHECK-LABEL: @foo(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[TMP0:%.*]] = load i8, ptr [[PTR0:%.*]], align 1
+; CHECK-NEXT: [[TMP1:%.*]] = zext i8 [[TMP0]] to i32
+; CHECK-NEXT: br label [[DO_BODY:%.*]]
+; CHECK: do.body:
+; CHECK-NEXT: [[TO_PROMOTE:%.*]] = phi i32 [ [[TMP1]], [[ENTRY:%.*]] ], [ [[TMP4:%.*]], [[DO_BODY]] ]
+; CHECK-NEXT: [[ARRAYIDX1:%.*]] = getelementptr inbounds i8, ptr [[PTR1:%.*]], i32 [[TO_PROMOTE]]
+; CHECK-NEXT: [[TMP2:%.*]] = load i8, ptr [[ARRAYIDX1]], align 2
+; CHECK-NEXT: [[TMP3:%.*]] = zext i8 [[TMP2]] to i32
+; CHECK-NEXT: [[COND_IN_I:%.*]] = getelementptr inbounds i8, ptr [[PTR1]], i32 [[TMP3]]
+; CHECK-NEXT: [[COND_I:%.*]] = load i8, ptr [[COND_IN_I]], align 1
+; CHECK-NEXT: [[TMP4]] = zext i8 [[COND_I]] to i32
+; CHECK-NEXT: store i8 [[TMP2]], ptr [[DEST:%.*]], align 1
+; CHECK-NEXT: [[CMP:%.*]] = icmp ult i32 [[TMP4]], 0
+; CHECK-NEXT: br i1 [[CMP]], label [[DO_BODY]], label [[DO_END:%.*]]
+; CHECK: do.end:
+; CHECK-NEXT: ret void
+;
+entry:
+ %0 = load i8, ptr %ptr0, align 1
+ br label %do.body
+
+do.body: ; preds = %do.body, %entry
+ %to_promote = phi i8 [ %0, %entry ], [ %cond.i, %do.body ]
+ %ext0 = zext i8 %to_promote to i32
+ %arrayidx1 = getelementptr inbounds i8, ptr %ptr1, i32 %ext0
+ %1 = load i8, ptr %arrayidx1, align 2
+ %2 = zext i8 %1 to i32
+ %cond.in.i = getelementptr inbounds i8, ptr %ptr1, i32 %2
+ %cond.i = load i8, ptr %cond.in.i, align 1
+ store i8 %1, ptr %dest, align 1
+ %cmp = icmp ult i8 %cond.i, 0
+ br i1 %cmp, label %do.body, label %do.end
+
+do.end: ; preds = %do.body
+ ret void
+}
diff --git a/llvm/test/Transforms/TypePromotion/ARM/phi-zext-gep2.ll b/llvm/test/Transforms/TypePromotion/ARM/phi-zext-gep2.ll
new file mode 100644
index 0000000000000..8ee5dd00a8da0
--- /dev/null
+++ b/llvm/test/Transforms/TypePromotion/ARM/phi-zext-gep2.ll
@@ -0,0 +1,42 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -mtriple=arm -type-promotion -verify -S %s -o - | FileCheck %s
+
+; Function Attrs: mustprogress nofree nosync nounwind uwtable
+define dso_local void @foo(ptr noundef %ptr0, ptr nocapture noundef readonly %ptr1, ptr nocapture noundef %dest) local_unnamed_addr {
+; CHECK-LABEL: @foo(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[TMP0:%.*]] = load i32, ptr [[PTR0:%.*]], align 1
+; CHECK-NEXT: br label [[DO_BODY:%.*]]
+; CHECK: do.body:
+; CHECK-NEXT: [[DONT_PROMOTE:%.*]] = phi i32 [ [[TMP0]], [[ENTRY:%.*]] ], [ [[COND_I:%.*]], [[DO_BODY]] ]
+; CHECK-NEXT: [[EXT0:%.*]] = zext i32 [[DONT_PROMOTE]] to i64
+; CHECK-NEXT: [[ARRAYIDX1:%.*]] = getelementptr inbounds i8, ptr [[PTR1:%.*]], i64 [[EXT0]]
+; CHECK-NEXT: [[TMP1:%.*]] = load i32, ptr [[ARRAYIDX1]], align 2
+; CHECK-NEXT: [[TMP2:%.*]] = zext i32 [[TMP1]] to i64
+; CHECK-NEXT: [[COND_IN_I:%.*]] = getelementptr inbounds i8, ptr [[PTR1]], i64 [[TMP2]]
+; CHECK-NEXT: [[COND_I]] = load i32, ptr [[COND_IN_I]], align 1
+; CHECK-NEXT: store i32 [[TMP1]], ptr [[DEST:%.*]], align 1
+; CHECK-NEXT: [[CMP:%.*]] = icmp ult i32 [[COND_I]], 0
+; CHECK-NEXT: br i1 [[CMP]], label [[DO_BODY]], label [[DO_END:%.*]]
+; CHECK: do.end:
+; CHECK-NEXT: ret void
+;
+entry:
+ %0 = load i32, ptr %ptr0, align 1
+ br label %do.body
+
+do.body: ; preds = %do.body, %entry
+ %dont_promote = phi i32 [ %0, %entry ], [ %cond.i, %do.body ]
+ %ext0 = zext i32 %dont_promote to i64
+ %arrayidx1 = getelementptr inbounds i8, ptr %ptr1, i64 %ext0
+ %1 = load i32, ptr %arrayidx1, align 2
+ %2 = zext i32 %1 to i64
+ %cond.in.i = getelementptr inbounds i8, ptr %ptr1, i64 %2
+ %cond.i = load i32, ptr %cond.in.i, align 1
+ store i32 %1, ptr %dest, align 1
+ %cmp = icmp ult i32 %cond.i, 0
+ br i1 %cmp, label %do.body, label %do.end
+
+do.end: ; preds = %do.body
+ ret void
+}
More information about the llvm-commits
mailing list