[PATCH] D113291: [AggressiveInstCombine] Lower Table Based CTTZ

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro marked 3 inline comments as done.
djtodoro added inline comments.


================
Comment at: llvm/lib/Transforms/AggressiveInstCombine/AggressiveInstCombine.cpp:485
+             m_ZExtOrSelf(m_LShr(
+                 m_ZExtOrSelf(m_Mul(m_c_And(m_Neg(m_Value(X1)), m_Deferred(X1)),
+                                    m_ConstantInt(MulConst))),
----------------
dmgreen wrote:
> Does the extend between the lshr and the mul every happen? From what I can tell, the type of the VT should be based on the type of these operations.
It does not happen in all the cases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113291/new/

https://reviews.llvm.org/D113291