[PATCH] D132012: [LoongArch] Add support for llvm.eh.dwarf.cfa

Lu Weining via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 00:16:46 PDT 2022


SixWeining added a comment.

Looks good to me except some nits. @wangleiat Do you have any comments?



================
Comment at: llvm/test/CodeGen/LoongArch/eh-dwarf-cfa.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=loongarch32 < %s | FileCheck -check-prefix=LA32 %s
+; RUN: llc -mtriple=loongarch64 < %s | FileCheck -check-prefix=LA64 %s
----------------
Use double dashes.


================
Comment at: llvm/test/CodeGen/LoongArch/eh-dwarf-cfa.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=loongarch32 < %s | FileCheck -check-prefix=LA32 %s
+; RUN: llc -mtriple=loongarch64 < %s | FileCheck -check-prefix=LA64 %s
----------------
SixWeining wrote:
> Use double dashes.
Ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132012/new/

https://reviews.llvm.org/D132012



More information about the llvm-commits mailing list