[PATCH] D132006: [LoongArch] Supports brcond with 21 bit offsets

[WÁNG Xuěruì via Phabricator via llvm-commits]

xen0n added a comment.

LGTM except the nit.



================
Comment at: llvm/test/CodeGen/LoongArch/bnez-beqz.ll:7
+
+define void @icmp_eq_i32(i32 signext %0) nounwind {
+; LA32-LABEL: icmp_eq_i32:
----------------
Isn't the "testcase name" misleading? It certainly is meant to exercise the `bnez` pattern with i32 icmp, so it could be better to name it `bnez_i32` instead.

Same with other cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132006/new/

https://reviews.llvm.org/D132006