[PATCH] D131941: [DAGCombiner][NFC] Merge two if statement into one

WangLian via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 16 18:55:54 PDT 2022


Jimerlife marked 2 inline comments as done.
Jimerlife added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4127
+    const APInt &C0 = N0.getConstantOperandAPInt(0);
+    const APInt &NewStep = C0 * MulVal;
+    return DAG.getStepVector(DL, VT, NewStep);
----------------
RKSimon wrote:
> NewStep isn't a reference - its a new result.
Thank you. It's a mistake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131941/new/

https://reviews.llvm.org/D131941



More information about the llvm-commits mailing list