[PATCH] D130052: [BOLT] Support passing fragments to code emission

[Rafael Auler via Phabricator via llvm-commits]

rafauler added inline comments.


================
Comment at: bolt/lib/Core/BinaryEmitter.cpp:387
+  MCSymbol *EndSymbol = FF.isSplitFragment()
+                            ? Function.getFunctionColdEndLabel()
+                            : Function.getFunctionEndLabel();
----------------
rafauler wrote:
> I guess the fact that we don't have individual end labels for each fragment is going to be a problem for determining the correct size of these symbols in emitELFSize. But according to 247b4181a306aff348c1d2d8c3847280866a7f32, this symbol table isn't terribly important. But I would rather not have incorrect code. 
I see this is implemented in https://reviews.llvm.org/D130520 now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130052/new/

https://reviews.llvm.org/D130052