[PATCH] D131343: [RISC-V][HWASAN] Add support for lowering HWASAN intrinsic for RISC-V

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

In D131343#3726862 <https://reviews.llvm.org/D131343#3726862>, @smd wrote:

> @vitalybuka
>
>> llvm/test/CodeGen/RISCV/hwasan-check-memaccess.ll ?
>> the test essentially validates LowerHWASAN_CHECK_MEMACCESS, and does not relies on the rest of D131344 <https://reviews.llvm.org/D131344>
>> So the test needs to be moved from D131344 <https://reviews.llvm.org/D131344> into this patch.
>
> I believe the same applies to D131575 <https://reviews.llvm.org/D131575> and basic.ll, where changes to instrumentMemAccessInline are tested? 
> If so, would you mind me moving hwasan-check-memaccess.ll to this patch and the rest of .ll tests to D131575 <https://reviews.llvm.org/D131575>?
> Thanks



In D131343#3726862 <https://reviews.llvm.org/D131343#3726862>, @smd wrote:

> @vitalybuka
>
>> llvm/test/CodeGen/RISCV/hwasan-check-memaccess.ll ?
>> the test essentially validates LowerHWASAN_CHECK_MEMACCESS, and does not relies on the rest of D131344 <https://reviews.llvm.org/D131344>
>> So the test needs to be moved from D131344 <https://reviews.llvm.org/D131344> into this patch.
>
> I believe the same applies to D131575 <https://reviews.llvm.org/D131575> and basic.ll, where changes to instrumentMemAccessInline are tested? 
> If so, would you mind me moving hwasan-check-memaccess.ll to this patch and the rest of .ll tests to D131575 <https://reviews.llvm.org/D131575>?
> Thanks

Sure. The logic is simple:

1. Split functional changes into smaller patches: AsmPrint, Instrumentation, RT ...
2. Each patch contains tests corresponding to changed functionality

So
test/CodeGen/RISCV/ goes into D131343 <https://reviews.llvm.org/D131343> (CodeGen patch)
test/Instrumentation/HWAddressSanitizer/RISCV/ into D131575 <https://reviews.llvm.org/D131575> (Instrumentation patch)

D131344 <https://reviews.llvm.org/D131344> should keep only compiler-rt/test/hwasan/TestCases/ as they look irrelevant to CodeGen and Instrumentation


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131343/new/

https://reviews.llvm.org/D131343