[PATCH] D131969: [gn build] build libclang_rt.ubsan_osx_dynamic.dylib on mac

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

We only ship the dynamic one in the chromium clang package, and it's enough to make things work.

...oh, looks like there's `-static-libsan` to pick the static lib, but the default is the dynamic one on mac (and fuchsia, and android): http://llvm-cs.pcc.me.uk/tools/clang/lib/Driver/SanitizerArgs.cpp#737 So we should probably try to get the shared version building on android too at least. And `-static-libsan` won't work in the GN build on mac until the static lib is built too.

And it looks like http://llvm-cs.pcc.me.uk/tools/clang/lib/Driver/SanitizerArgs.cpp#267 , http://llvm-cs.pcc.me.uk/tools/clang/lib/Driver/ToolChains/Darwin.cpp#1187 mean that fsanitize-minimal-runtime won't work for now either.

I'll update the patch description with this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131969/new/

https://reviews.llvm.org/D131969