[PATCH] D131980: [Passes] Don't run tail-call-elim in -O1
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 16 10:52:39 PDT 2022
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM
These clang tests are just awful, but I don't have the patience to fix them...
================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:245
// TODO: Investigate the cost/benefit of tail call elimination on debugging.
FunctionPassManager
----------------
Update this comment? IIUC, we are decisively saying that tail call elim is not worth the impact to debuggability for -O1. That way, someone -- possibly me again :) -- won't try to unknowingly change this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131980/new/
https://reviews.llvm.org/D131980
More information about the llvm-commits
mailing list